[clang] [analyzer] Modernize, improve and promote chroot checker (PR #117791)

[Balazs Benics via cfe-commits]

================
@@ -104,15 +146,35 @@ void ChrootChecker::evalChdir(const CallEvent &Call, CheckerContext &C) const {
     R = R->StripCasts();
     if (const StringRegion* StrRegion= dyn_cast<StringRegion>(R)) {
       const StringLiteral* Str = StrRegion->getStringLiteral();
-      if (Str->getString() == "/")
-        state = Mgr.addGDM(state, ChrootChecker::getTag(),
-                           (void*) JAIL_ENTERED);
+      if (Str->getString() == "/") {
----------------
steakhal wrote:

I think we could just inline `Str`.
```suggestion
      if (StrRegion->getStringLiteral()->getString() == "/") {
```

https://github.com/llvm/llvm-project/pull/117791