[clang-tools-extra] [clang-tidy] modernize-make-shared: Add MakeSmartPtrType option (PR #117529)

Helmut Januschka via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 26 13:26:34 PST 2024


https://github.com/hjanuschka commented:

@PiotrZSL 
  - [x]  Add MakeSmartPtrType in MakeSmartPtrCheck as protected (do not initialize in constructor)
  - [x]  Add MakeSmartPtrType to storeOptions
  - [x]  Read MakeSmartPtrType in MakeSharedPtrCheck & MakeUniquePtrCheck constructors (set different default values)
  - [x]  Use MakeSmartPtrType in getSmartPointerTypeMatcher in both classes
  - [x]  Modify documentation for both checks
  - [x]   Add entry for both checks in release notes
  - [x]   Consider doing same for 'std::make_shared'


> Consider supporting multiple smart ptr types and multiple make functions
a bit unsure about this one, do you have any sample where there is usage of multiple?! 
really not sure about this! the rest is addressed, and ready for another review

https://github.com/llvm/llvm-project/pull/117529


More information about the cfe-commits mailing list