[clang] [llvm] [NFC][clang][FMV][TargetInfo] Refactor API for FMV feature priority. (PR #116257)

Alexandros Lamprineas via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 25 23:53:45 PST 2024


================
@@ -4303,21 +4288,15 @@ void CodeGenModule::emitMultiVersionFunctions() {
                 continue;
 
               llvm::Function *Func = createFunction(CurFD, I);
-              StringRef Architecture;
               Feats.clear();
-              if (getTarget().getTriple().isAArch64())
-                TC->getFeatures(Feats, I);
-              else if (getTarget().getTriple().isRISCV()) {
-                StringRef Version = TC->getFeatureStr(I);
-                Feats.push_back(Version);
+              if (getTarget().getTriple().isX86()) {
+                TC->getAddedFeatures(Feats, I);
----------------
labrinea wrote:

Yes, as I said earlier the struct MultiVersionResolverOption (see https://github.com/llvm/llvm-project/pull/116257/files#diff-731858fb71c12faa05d9549cf109d33744fa2e070c06d1740b9020c66e7d143eL5335) was originally tailored to x86. The `Architecture` field is used here: https://github.com/llvm/llvm-project/pull/116257/files#diff-9f23818ed51d0b117b5692129d0801721283d0f128a01cbc562353da0266d7adL2842.

https://github.com/llvm/llvm-project/pull/116257


More information about the cfe-commits mailing list