[clang] [Clang] [Parser] Fixing all callers of `ParseExternalDeclaration` that didn't parse gnu attributes (PR #117148)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 25 10:24:57 PST 2024
================
@@ -2314,10 +2314,12 @@ Parser::DeclGroupPtrTy Parser::ParseOpenMPDeclarativeDirectiveWithExtDecl(
// Here we expect to see some function declaration.
if (AS == AS_none) {
assert(TagType == DeclSpec::TST_unspecified);
- ParsedAttributes EmptyDeclSpecAttrs(AttrFactory);
- MaybeParseCXX11Attributes(Attrs);
+ ParsedAttributes DeclSpecAttrs(AttrFactory);
----------------
erichkeane wrote:
Why isn't this calling the new function? It seems you've added the `ParsingDeclSpec` default argument correctly, so I don't see a reason to not have this call the new one too.
https://github.com/llvm/llvm-project/pull/117148
More information about the cfe-commits
mailing list