[clang-tools-extra] Rename CODE_OWNERS -> Maintainers (PR #114544)
Aaron Ballman via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 25 10:02:25 PST 2024
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/114544
>From 6a9f356c13a2a391909cc2161318e4d6300e6a48 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Fri, 1 Nov 2024 10:43:14 -0400
Subject: [PATCH 1/9] Rename CODE_OWNERS -> Maintainers
---
clang-tools-extra/CODE_OWNERS.TXT | 30 ----------------------
clang-tools-extra/Maintainers.txt | 42 +++++++++++++++++++++++++++++++
2 files changed, 42 insertions(+), 30 deletions(-)
delete mode 100644 clang-tools-extra/CODE_OWNERS.TXT
create mode 100644 clang-tools-extra/Maintainers.txt
diff --git a/clang-tools-extra/CODE_OWNERS.TXT b/clang-tools-extra/CODE_OWNERS.TXT
deleted file mode 100644
index 2831ec7e25f59f..00000000000000
--- a/clang-tools-extra/CODE_OWNERS.TXT
+++ /dev/null
@@ -1,30 +0,0 @@
-This file is a list of the people responsible for ensuring that patches for a
-particular tool are reviewed, either by themself or by someone else. They are
-also the gatekeepers for their part of Clang, with the final word on what goes
-in or not.
-
-The list is sorted by surname and formatted to allow easy grepping and
-beautification by scripts. The fields are: name (N), email (E), Phabricator
-handle (H), and description (D).
-
-N: Aaron Ballman
-E: aaron at aaronballman.com
-H: aaron.ballman
-D: clang-query
-
-N: Julie Hockett
-E: juliehockett at google.com
-D: clang-doc
-
-N: Nathan James
-E: n.james93 at hotmail.co.uk
-H: njames93
-D: clang-tidy
-
-N: Manuel Klimek
-E: klimek at google.com
-D: all parts of clang-tools-extra not covered by someone else
-
-N: Sam McCall
-E: sammccall at google.com
-D: clangd
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
new file mode 100644
index 00000000000000..dc60b3717c63bb
--- /dev/null
+++ b/clang-tools-extra/Maintainers.txt
@@ -0,0 +1,42 @@
+=============================
+Clang Tools Extra Maintainers
+=============================
+
+This file is a list of the maintainers
+(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra.
+
+
+Active Maintainers
+==================
+The following people are the active maintainers for the project. Please reach
+out to them for code reviews, questions about their area of expertise, or other
+assistance.
+
+Lead Maintainer
+---------------
+| Manuel Klimek
+| klimek at google.com (email), r4nt (GitHub)
+
+
+clang-query
+-----------
+| Aaron Ballman
+| aaron at aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
+
+
+clang-doc
+---------
+| Julie Hockett
+| juliehockett at google.com (email)
+
+
+clang-tidy
+----------
+| Nathan James
+| n.james93 at hotmail.co.uk (email), njames93 (GitHub)
+
+
+clangd
+------
+| Sam McCall
+| sammccall at google.com (email), sam-mccall (GitHub), sam-mccall (Discourse), sam-mccall (Discord)
>From 37469f955bc3afecc8b6c0db9624cd6c932e895e Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Fri, 1 Nov 2024 11:01:23 -0400
Subject: [PATCH 2/9] Move Nathan to the inactive maintainers section
Based on review feedback from Nathan -- thank you for all the help!
---
clang-tools-extra/Maintainers.txt | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index dc60b3717c63bb..db6091175d6c66 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -30,13 +30,18 @@ clang-doc
| juliehockett at google.com (email)
-clang-tidy
-----------
-| Nathan James
-| n.james93 at hotmail.co.uk (email), njames93 (GitHub)
-
-
clangd
------
| Sam McCall
| sammccall at google.com (email), sam-mccall (GitHub), sam-mccall (Discourse), sam-mccall (Discord)
+
+
+Inactive Maintainers
+====================
+The following people have graciously spent time performing maintainership
+responsibilities but are no longer active in that role. Thank you for all your
+help with the success of the project!
+
+Inactive component maintainers
+------------------------------
+| Nathan James (n.james93 at hotmail.co.uk) -- clang-tidy
>From 54b478eeaeeaa0c7bb0b58630e2d3d12100d2c9c Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 13 Nov 2024 10:39:37 -0500
Subject: [PATCH 3/9] Add Congcong Cai as a maintainer for clang-tidy
---
clang-tools-extra/Maintainers.txt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index db6091175d6c66..61fd049ec168b8 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -18,6 +18,12 @@ Lead Maintainer
| klimek at google.com (email), r4nt (GitHub)
+clang-tidy
+----------
+| Congcong Cai
+| congcongcai0907\@163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
+
+
clang-query
-----------
| Aaron Ballman
>From c7c2e377a68b6a2a4931f38ef813124fe5aa04b2 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 13 Nov 2024 14:02:07 -0500
Subject: [PATCH 4/9] Add Julian Schmidt as a maintainer for clang-tidy
---
clang-tools-extra/Maintainers.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index 61fd049ec168b8..b6ac5651006bc2 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -23,6 +23,9 @@ clang-tidy
| Congcong Cai
| congcongcai0907\@163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
+| Julian Schmidt
+| git.julian.schmidt\@gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
+
clang-query
-----------
>From 307b210f270b6eeb1d860fd570de227def325ee1 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 13 Nov 2024 14:18:19 -0500
Subject: [PATCH 5/9] No need to escape the @
---
clang-tools-extra/Maintainers.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index b6ac5651006bc2..c3536a570fb519 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -21,10 +21,10 @@ Lead Maintainer
clang-tidy
----------
| Congcong Cai
-| congcongcai0907\@163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
+| congcongcai0907 at 163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
| Julian Schmidt
-| git.julian.schmidt\@gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
+| git.julian.schmidt at gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
clang-query
>From f40a101b270e11b911ec87723603d4db5432d57d Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Fri, 15 Nov 2024 08:02:36 -0500
Subject: [PATCH 6/9] Add maintainers for clang-doc and clangd
---
clang-tools-extra/Maintainers.txt | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index c3536a570fb519..7fa902b02e4193 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -35,14 +35,23 @@ clang-query
clang-doc
---------
-| Julie Hockett
-| juliehockett at google.com (email)
+| Paul Kirth
+| paulkirth at google.com (email), ilovepi (GitHub), ilovepi (Discourse)
+
+| Peter Chou
+| peter.chou at mail.utoronto.ca (email), PeterChou1 (GitHub), PeterChou1 (Discourse), .peterchou (Discord)
clangd
------
-| Sam McCall
-| sammccall at google.com (email), sam-mccall (GitHub), sam-mccall (Discourse), sam-mccall (Discord)
+| Nathan Ridge
+| zeratul976 at hotmail.com (email), HighCommander4 (GitHub), HighCommander4 (Discourse), nridge (Discord)
+
+| Chris Bieneman
+| chris.bieneman at gmail.com (email), llvm-beanz (GitHub), beanz (Discord), beanz (Discourse)
+
+| Kadir Çetinkaya
+| kadircet at google.com (email), kadircet (GitHub) kadircet (Discourse), kadircet (Discord)
Inactive Maintainers
@@ -54,3 +63,5 @@ help with the success of the project!
Inactive component maintainers
------------------------------
| Nathan James (n.james93 at hotmail.co.uk) -- clang-tidy
+| Julie Hockett (juliehockett at google.com) -- clang-doc
+| Sam McCall (sammccall at google.com (email), sam-mccall (GitHub, Discourse, Discord)) -- clangd
>From 3da7be5c5011a4afdfcd28bb25d118eed790b6c9 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Tue, 19 Nov 2024 14:27:41 -0500
Subject: [PATCH 7/9] Add Manuel as an emeritus lead maintainer, add myself as
the new lead
Manuel has been unresponsive on the PR and the post on Discourse, but
he had previously stepped down as a component maintainer in Clang due
to a lack of bandwidth, so I think it's safe to move him to the
inactive list.
If he wants to be lead again, I'll happily pass the duties back to him.
---
clang-tools-extra/Maintainers.txt | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index 7fa902b02e4193..7d2cf87ed14e0b 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -14,8 +14,8 @@ assistance.
Lead Maintainer
---------------
-| Manuel Klimek
-| klimek at google.com (email), r4nt (GitHub)
+| Aaron Ballman
+| aaron at aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
clang-tidy
@@ -60,6 +60,11 @@ The following people have graciously spent time performing maintainership
responsibilities but are no longer active in that role. Thank you for all your
help with the success of the project!
+Emeritus Lead Maintainers
+-------------------------
+| Manuel Klimek (klimek at google.com (email), r4nt (GitHub))
+
+
Inactive component maintainers
------------------------------
| Nathan James (n.james93 at hotmail.co.uk) -- clang-tidy
>From 354b0e0d52b18b833663953ed9691fa8b47325e3 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 20 Nov 2024 08:16:11 -0500
Subject: [PATCH 8/9] Update email address for Peter Chou
---
clang-tools-extra/Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index 7d2cf87ed14e0b..8d16bdaf7cca61 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -39,7 +39,7 @@ clang-doc
| paulkirth at google.com (email), ilovepi (GitHub), ilovepi (Discourse)
| Peter Chou
-| peter.chou at mail.utoronto.ca (email), PeterChou1 (GitHub), PeterChou1 (Discourse), .peterchou (Discord)
+| peterchou411 at gmail.com (email), PeterChou1 (GitHub), PeterChou1 (Discourse), .peterchou (Discord)
clangd
>From 5fbf96b525f993dc69e9b0735d642242880f3de8 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Mon, 25 Nov 2024 13:02:13 -0500
Subject: [PATCH 9/9] Update clang-tools-extra/Maintainers.txt
Co-authored-by: Piotr Zegar <me at piotrzegar.pl>
---
clang-tools-extra/Maintainers.txt | 3 +++
1 file changed, 3 insertions(+)
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index 8d16bdaf7cca61..689f2408820e99 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -26,6 +26,9 @@ clang-tidy
| Julian Schmidt
| git.julian.schmidt at gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
+| Piotr Zegar
+| me at piotrzegar.pl (email), PiotrZSL (GitHub), PiotrZSL (Discourse), PiotrZSL (Discord)
+
clang-query
-----------
More information about the cfe-commits
mailing list