https://github.com/erichkeane commented: I don't think I'm needed on this review again, but did a pass through and had some comments/suggestions. Nothing binding, so I'll let others discuss this/accept this. https://github.com/llvm/llvm-project/pull/98788