[clang] [clang][ARM] disable frame pointers by default for bare metal ARM targets (PR #117140)

Ties Stuij via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 25 09:21:33 PST 2024


stuij wrote:

I feel that in `useFramePointerForTargetByDef` fn, in general things are predicated first on platform and then on arch. That L85 arch switch statement seems to serve as a "these arches don't do anything special" early return.

It's up to interpretation, but putting the different Arm variants there seems less elegant to me (that might not be saying much..). I'd say let's leave it alone for now, and if the bare metal logic gets more impenetrable at some point, refactor.

 

https://github.com/llvm/llvm-project/pull/117140


More information about the cfe-commits mailing list