[clang] 14b9ca3 - [Sema] Fix a warning

Kazu Hirata via cfe-commits cfe-commits at lists.llvm.org
Sat Nov 23 10:29:17 PST 2024


Author: Kazu Hirata
Date: 2024-11-23T10:29:11-08:00
New Revision: 14b9ca3f38494bbd03709188b6e73c06ab84cd15

URL: https://github.com/llvm/llvm-project/commit/14b9ca3f38494bbd03709188b6e73c06ab84cd15
DIFF: https://github.com/llvm/llvm-project/commit/14b9ca3f38494bbd03709188b6e73c06ab84cd15.diff

LOG: [Sema] Fix a warning

This patch fixes:

  clang/lib/Sema/SemaHLSL.cpp:2225:32: error: absolute value function
  'abs' given an argument of type 'int64_t' (aka 'long') but has
  parameter of type 'int' which may cause truncation of value
  [-Werror,-Wabsolute-value]

Added: 
    

Modified: 
    clang/lib/Sema/SemaHLSL.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Sema/SemaHLSL.cpp b/clang/lib/Sema/SemaHLSL.cpp
index 289d9dc0f11306..8bdacd6ded1654 100644
--- a/clang/lib/Sema/SemaHLSL.cpp
+++ b/clang/lib/Sema/SemaHLSL.cpp
@@ -2222,7 +2222,7 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) {
     Expr *OffsetExpr = TheCall->getArg(1);
     std::optional<llvm::APSInt> Offset =
         OffsetExpr->getIntegerConstantExpr(SemaRef.getASTContext());
-    if (!Offset.has_value() || abs(Offset->getExtValue()) != 1) {
+    if (!Offset.has_value() || std::abs(Offset->getExtValue()) != 1) {
       SemaRef.Diag(TheCall->getArg(1)->getBeginLoc(),
                    diag::err_hlsl_expect_arg_const_int_one_or_neg_one)
           << 1;


        


More information about the cfe-commits mailing list