[clang] [HLSL] Implement SV_GroupID semantic (PR #115911)

[Chris B via cfe-commits]

================
@@ -784,6 +785,17 @@ void SemaHLSL::handleSV_DispatchThreadIDAttr(Decl *D, const ParsedAttr &AL) {
                  HLSLSV_DispatchThreadIDAttr(getASTContext(), AL));
 }
 
+void SemaHLSL::handleSV_GroupIDAttr(Decl *D, const ParsedAttr &AL) {
+  auto *VD = cast<ValueDecl>(D);
+  if (!isLegalTypeForHLSLSV_ThreadOrGroupID(VD->getType())) {
+    Diag(AL.getLoc(), diag::err_hlsl_attr_invalid_type)
+        << AL << "uint/uint2/uint3";
----------------
llvm-beanz wrote:

Also, it is important that the function be named for what it does, so if you moved the diagnostic into the function it should be called `diagnose...` rather than `is...`.

https://github.com/llvm/llvm-project/pull/115911