[clang] [lld] [llvm] [WebAssembly] Define call-indirect-overlong and bulk-memory-opt features (PR #117087)

Heejin Ahn via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 17:29:56 PST 2024


================
@@ -265,6 +279,14 @@ bool WebAssemblyTargetInfo::handleTargetFeatures(
       HasReferenceTypes = false;
       continue;
     }
+    if (Feature == "+call-indirect-overlong") {
+      HasCallIndirectOverlong = true;
+      continue;
+    }
+    if (Feature == "-call-indirect-overlong") {
+      HasCallIndirectOverlong = false;
+      continue;
+    }
----------------
aheejin wrote:

Nit: 
I understand why this was put after `reference-types`, because this is a subset of that, 
but the feature names here and elsewhere are sorted by the feature name's alphabetical order so I think `-call-indirect-overlong` could go right after `-bulk-memory-opt`. All other places too. Yeah it's probably my OCD 😅 But having them sorted helped me find missing tings easier...

https://github.com/llvm/llvm-project/pull/117087


More information about the cfe-commits mailing list