[clang] eaa0a21 - Limit symbol versioning in clang-cpp to Linux for now

Aaron Puchert via cfe-commits cfe-commits at lists.llvm.org
Thu Nov 21 14:53:41 PST 2024


Author: Aaron Puchert
Date: 2024-11-21T23:53:11+01:00
New Revision: eaa0a21d21962280dc2c03a09152510f6162a576

URL: https://github.com/llvm/llvm-project/commit/eaa0a21d21962280dc2c03a09152510f6162a576
DIFF: https://github.com/llvm/llvm-project/commit/eaa0a21d21962280dc2c03a09152510f6162a576.diff

LOG: Limit symbol versioning in clang-cpp to Linux for now

There was a build bot failure on AIX after #116556, and who knows what
other systems don't support symbol versioning. So let's limit this to
Linux for now. We can always add more cases later.

Added: 
    

Modified: 
    clang/tools/clang-shlib/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
index d83c13fd394f43..31484ec49c7739 100644
--- a/clang/tools/clang-shlib/CMakeLists.txt
+++ b/clang/tools/clang-shlib/CMakeLists.txt
@@ -51,8 +51,7 @@ add_clang_library(clang-cpp
 
 configure_file(simple_version_script.map.in simple_version_script.map)
 
-if (NOT APPLE AND NOT MSVC AND NOT MINGW AND NOT LLVM_LINKER_IS_SOLARISLD)
-  # Solaris ld does not accept global: *; so there is no way to version *all* global symbols
+if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
   target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
 endif()
 


        


More information about the cfe-commits mailing list