[clang] [Clang] [Parser] Fixing all callers of `ParseExternalDeclaration` that didn't parse gnu attributes (PR #117148)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Nov 21 05:46:53 PST 2024
================
@@ -267,9 +267,11 @@ void Parser::ParseInnerNamespace(const InnerNamespaceInfoList &InnerNSs,
while (!tryParseMisplacedModuleImport() && Tok.isNot(tok::r_brace) &&
Tok.isNot(tok::eof)) {
ParsedAttributes DeclAttrs(AttrFactory);
- MaybeParseCXX11Attributes(DeclAttrs);
- ParsedAttributes EmptyDeclSpecAttrs(AttrFactory);
- ParseExternalDeclaration(DeclAttrs, EmptyDeclSpecAttrs);
+ ParsedAttributes DeclSpecAttrs(AttrFactory);
+ while (MaybeParseCXX11Attributes(DeclAttrs) ||
+ MaybeParseGNUAttributes(DeclSpecAttrs))
+ ;
----------------
Sirraide wrote:
Actually, there is a TODO in ParseDeclCXX.cpp to factor out this (including the call to `ParseExternalDeclaration`) in `Parser::ParseExportDeclaration`, so now might be a good time to do that.
https://github.com/llvm/llvm-project/pull/117148
More information about the cfe-commits
mailing list