[clang] Revert "[TargetVersion] Only enable on RISC-V and AArch64" (PR #117110)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 20 20:48:23 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Piyou Chen (BeMg)
<details>
<summary>Changes</summary>
Reverts llvm/llvm-project#<!-- -->115991
Due to build fail https://lab.llvm.org/buildbot/#/builders/66/builds/6511
---
Full diff: https://github.com/llvm/llvm-project/pull/117110.diff
3 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (-2)
- (modified) clang/include/clang/Basic/Attr.td (+1-1)
- (removed) clang/test/Sema/attr-target-version-unsupported.c (-4)
``````````diff
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index a2ff05438c949a..999c88455b64a5 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -459,8 +459,6 @@ Attribute Changes in Clang
- Clang now supports ``[[clang::lifetime_capture_by(X)]]``. Similar to lifetimebound, this can be
used to specify when a reference to a function parameter is captured by another capturing entity ``X``.
-- The ``target_version`` attribute is now only supported for AArch64 and RISC-V architectures.
-
Improvements to Clang's diagnostics
-----------------------------------
diff --git a/clang/include/clang/Basic/Attr.td b/clang/include/clang/Basic/Attr.td
index f1780fa1067352..634253d0032560 100644
--- a/clang/include/clang/Basic/Attr.td
+++ b/clang/include/clang/Basic/Attr.td
@@ -3297,7 +3297,7 @@ def Target : InheritableAttr {
}];
}
-def TargetVersion : DeclOrTypeAttr, TargetSpecificAttr<TargetArch<!listconcat(TargetAArch64.Arches, TargetRISCV.Arches)>> {
+def TargetVersion : InheritableAttr {
let Spellings = [GCC<"target_version">];
let Args = [StringArgument<"NamesStr">];
let Subjects = SubjectList<[Function], ErrorDiag>;
diff --git a/clang/test/Sema/attr-target-version-unsupported.c b/clang/test/Sema/attr-target-version-unsupported.c
deleted file mode 100644
index 7cf8172f5272e6..00000000000000
--- a/clang/test/Sema/attr-target-version-unsupported.c
+++ /dev/null
@@ -1,4 +0,0 @@
-// RUN: %clang_cc1 -triple x86_64-unknown-unknown -fsyntax-only -verify %s
-
-//expected-warning at +1 {{unknown attribute 'target_version' ignored}}
-int __attribute__((target_version("aes"))) foo(void) { return 3; }
``````````
</details>
https://github.com/llvm/llvm-project/pull/117110
More information about the cfe-commits
mailing list