[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

Farzon Lotfi via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 20 09:58:54 PST 2024


================
@@ -1949,24 +1955,48 @@ bool SPIRVInstructionSelector::selectSign(Register ResVReg,
   return Result;
 }
 
+bool SPIRVInstructionSelector::selectWaveNOpInst(Register ResVReg,
+                                                 const SPIRVType *ResType,
+                                                 MachineInstr &I,
+                                                 unsigned Opcode,
+                                                 unsigned OperandCount) const {
+  assert(I.getNumOperands() == OperandCount);
----------------
farzonl wrote:

Number of operands per opcode is already determined in the tablegen. Nothing is going to change that. This just adds a pain point for users of this function where they think they can specify the operand length first build and test fails and then they do what tablegen defined on the second build.  We should avoid creating apis that can mislead users.

https://github.com/llvm/llvm-project/pull/115902


More information about the cfe-commits mailing list