[clang] [llvm] [HLSL] Implement WaveActiveAnyTrue intrinsic (PR #115902)

Ashley Coleman via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 20 09:51:48 PST 2024


================
@@ -1949,24 +1955,48 @@ bool SPIRVInstructionSelector::selectSign(Register ResVReg,
   return Result;
 }
 
+bool SPIRVInstructionSelector::selectWaveNOpInst(Register ResVReg,
+                                                 const SPIRVType *ResType,
+                                                 MachineInstr &I,
+                                                 unsigned Opcode,
+                                                 unsigned OperandCount) const {
+  assert(I.getNumOperands() == OperandCount);
----------------
V-FEXrt wrote:

I was just blindly refactoring, but one could argue that asserting the expected `OperandCount` is safer from a "is this doing what I expect" angle

https://github.com/llvm/llvm-project/pull/115902


More information about the cfe-commits mailing list