[clang] [clang-tools-extra] [clangd] Update clangDaemonTweaks to set symbol visibility macros (PR #112304)

Saleem Abdulrasool via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 19 10:14:17 PST 2024


================
@@ -114,7 +114,7 @@ macro(add_clang_library name)
     if(TARGET "obj.${name}")
       target_compile_definitions("obj.${name}" PUBLIC CLANG_BUILD_STATIC)
     endif()
-  elseif(NOT ARG_SHARED AND NOT ARG_STATIC)
+  elseif(NOT ARG_SHARED AND NOT ARG_STATIC AND NOT ARG_CLANG_IMPORT)
----------------
compnerd wrote:

Then we should be using `if (NOT DEFINED ...)`. The syntax you have can check for the truthiness of the value.

https://github.com/llvm/llvm-project/pull/112304


More information about the cfe-commits mailing list