[clang-tools-extra] [clang-tidy] Enhance modernize-use-starts-ends-with to handle substr patterns (PR #116033)
Nicolas van Kempen via cfe-commits
cfe-commits at lists.llvm.org
Mon Nov 18 08:18:45 PST 2024
================
@@ -71,6 +71,17 @@ struct NotLengthExprForStringNode {
ASTContext *Context;
};
+static bool isNegativeComparison(const Expr *ComparisonExpr) {
+ if (const auto *BO = llvm::dyn_cast<BinaryOperator>(ComparisonExpr)) {
+ return BO->getOpcode() == BO_NE;
+ }
----------------
nicovank wrote:
Nit: personally I also prefer braces in all cases but LLVM style says no braces for short single statements like this one.
```suggestion
if (const auto *BO = llvm::dyn_cast<BinaryOperator>(ComparisonExpr))
return BO->getOpcode() == BO_NE;
```
https://github.com/llvm/llvm-project/pull/116033
More information about the cfe-commits
mailing list