[clang] [clang][Driver] Use shared_ptr in the Compilation class (PR #116406)

David Truby via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 18 06:36:06 PST 2024


https://github.com/DavidTruby requested changes to this pull request.

Thanks for the patch!
I don't think there's any actual shared ownership happening here so I think you could use `unique_ptr` instead, and that has lower overhead so would be preferable I think.

I've left a comment as to why the patch fails the CI at the moment too.

https://github.com/llvm/llvm-project/pull/116406


More information about the cfe-commits mailing list