[clang] [llvm] [SPIR-V] DRAFT: Shader built-ins - no spec change (PR #116393)

Nathan Gauër via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 18 05:53:52 PST 2024


================
@@ -59,6 +59,9 @@ enum class LangAS : unsigned {
   // HLSL specific address spaces.
   hlsl_groupshared,
 
+  // Vulkan specific address spaces.
+  vulkan_private,
+
----------------
Keenuts wrote:

It breaks 1 test, but the test seems wrong anyway: test for SPV_INTEL_function_pointers, which is not official IIRC (could only find https://github.com/intel/llvm/blob/sycl/sycl/doc/design/spirv-extensions/SPV_INTEL_function_pointers.asciidoc ) and the spec seems to require the SC to be `CodeSectionINTEL` and the test expects it to be `Function`.
Anyway, if MS approves the overall direction to go through this Ctor/Dtor, I'll make a real PR with those changes, and not use a custom AS

https://github.com/llvm/llvm-project/pull/116393


More information about the cfe-commits mailing list