[clang] [ASTWriter] Do not allocate source location space for module maps used only for textual headers (PR #116374)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 15 03:31:18 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 469f9d5fb8fcfe7dc42baa2daa7e230147f234de ff328f256824e30b2c3c8db184a0fcafaef32637 --extensions cpp -- clang/test/Modules/prune-non-affecting-module-map-repeated-textual.cpp clang/lib/Serialization/ASTWriter.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp
index a0d0e03178..9b81d7c53f 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -195,7 +195,8 @@ GetAffectingModuleMaps(const Preprocessor &PP, Module *RootModule) {
};
llvm::DenseMap<FileID, AffectedReason> ModuleMaps;
llvm::DenseMap<const Module *, AffectedReason> ProcessedModules;
- auto CollectModuleMapsForHierarchy = [&](const Module *M, AffectedReason Reason) {
+ auto CollectModuleMapsForHierarchy = [&](const Module *M,
+ AffectedReason Reason) {
M = M->getTopLevelModule();
// We need to process the header either when it was not present of when we
``````````
</details>
https://github.com/llvm/llvm-project/pull/116374
More information about the cfe-commits
mailing list