[clang] [Clang] add single quotes around __builtin_bit_cast (PR #116120)
via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 13 15:36:42 PST 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Oleksandr T. (a-tarasyuk)
<details>
<summary>Changes</summary>
Fixes https://github.com/llvm/llvm-project/issues/116118
---
Full diff: https://github.com/llvm/llvm-project/pull/116120.diff
2 Files Affected:
- (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+1-1)
- (modified) clang/test/SemaCXX/builtin-bit-cast.cpp (+2-2)
``````````diff
diff --git a/clang/include/clang/Basic/DiagnosticSemaKinds.td b/clang/include/clang/Basic/DiagnosticSemaKinds.td
index 17eb28e8fc5623..de2438e5e9032f 100644
--- a/clang/include/clang/Basic/DiagnosticSemaKinds.td
+++ b/clang/include/clang/Basic/DiagnosticSemaKinds.td
@@ -12366,7 +12366,7 @@ def err_preserve_enum_value_not_const: Error<
"__builtin_preserve_enum_value argument %0 not a constant">;
def err_bit_cast_non_trivially_copyable : Error<
- "__builtin_bit_cast %select{source|destination}0 type must be trivially copyable">;
+ "'__builtin_bit_cast' %select{source|destination}0 type must be trivially copyable">;
def err_bit_cast_type_size_mismatch : Error<
"size of '__builtin_bit_cast' source type %0 does not match destination type %1 (%2 vs %3 bytes)">;
diff --git a/clang/test/SemaCXX/builtin-bit-cast.cpp b/clang/test/SemaCXX/builtin-bit-cast.cpp
index d7f24c7939b558..8717371b941b0d 100644
--- a/clang/test/SemaCXX/builtin-bit-cast.cpp
+++ b/clang/test/SemaCXX/builtin-bit-cast.cpp
@@ -32,10 +32,10 @@ struct not_trivially_copyable {
virtual void foo() {}
};
-// expected-error at +1{{__builtin_bit_cast source type must be trivially copyable}}
+// expected-error at +1{{'__builtin_bit_cast' source type must be trivially copyable}}
constexpr unsigned long ul = __builtin_bit_cast(unsigned long, not_trivially_copyable{});
-// expected-error at +1 {{__builtin_bit_cast destination type must be trivially copyable}}
+// expected-error at +1 {{'__builtin_bit_cast' destination type must be trivially copyable}}
constexpr long us = __builtin_bit_cast(unsigned long &, 0L);
namespace PR42936 {
``````````
</details>
https://github.com/llvm/llvm-project/pull/116120
More information about the cfe-commits
mailing list