[clang-tools-extra] Rename CODE_OWNERS -> Maintainers (PR #114544)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 13 11:19:04 PST 2024


https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/114544

>From 6a9f356c13a2a391909cc2161318e4d6300e6a48 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Fri, 1 Nov 2024 10:43:14 -0400
Subject: [PATCH 1/5] Rename CODE_OWNERS -> Maintainers

---
 clang-tools-extra/CODE_OWNERS.TXT | 30 ----------------------
 clang-tools-extra/Maintainers.txt | 42 +++++++++++++++++++++++++++++++
 2 files changed, 42 insertions(+), 30 deletions(-)
 delete mode 100644 clang-tools-extra/CODE_OWNERS.TXT
 create mode 100644 clang-tools-extra/Maintainers.txt

diff --git a/clang-tools-extra/CODE_OWNERS.TXT b/clang-tools-extra/CODE_OWNERS.TXT
deleted file mode 100644
index 2831ec7e25f59f..00000000000000
--- a/clang-tools-extra/CODE_OWNERS.TXT
+++ /dev/null
@@ -1,30 +0,0 @@
-This file is a list of the people responsible for ensuring that patches for a
-particular tool are reviewed, either by themself or by someone else. They are
-also the gatekeepers for their part of Clang, with the final word on what goes
-in or not.
-
-The list is sorted by surname and formatted to allow easy grepping and
-beautification by scripts.  The fields are: name (N), email (E), Phabricator
-handle (H), and description (D).
-
-N: Aaron Ballman
-E: aaron at aaronballman.com
-H: aaron.ballman
-D: clang-query
-
-N: Julie Hockett
-E: juliehockett at google.com
-D: clang-doc
-
-N: Nathan James
-E: n.james93 at hotmail.co.uk
-H: njames93
-D: clang-tidy
-
-N: Manuel Klimek
-E: klimek at google.com
-D: all parts of clang-tools-extra not covered by someone else
-
-N: Sam McCall
-E: sammccall at google.com
-D: clangd
diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
new file mode 100644
index 00000000000000..dc60b3717c63bb
--- /dev/null
+++ b/clang-tools-extra/Maintainers.txt
@@ -0,0 +1,42 @@
+=============================
+Clang Tools Extra Maintainers
+=============================
+
+This file is a list of the maintainers
+(https://llvm.org/docs/DeveloperPolicy.html#maintainers) for clang-tools-extra.
+
+
+Active Maintainers
+==================
+The following people are the active maintainers for the project. Please reach
+out to them for code reviews, questions about their area of expertise, or other
+assistance.
+
+Lead Maintainer
+---------------
+| Manuel Klimek
+| klimek at google.com (email), r4nt (GitHub)
+
+
+clang-query
+-----------
+| Aaron Ballman
+| aaron at aaronballman.com (email), aaron.ballman (Phabricator), AaronBallman (GitHub), AaronBallman (Discourse), aaronballman (Discord), AaronBallman (IRC)
+
+
+clang-doc
+---------
+| Julie Hockett
+| juliehockett at google.com (email)
+
+
+clang-tidy
+----------
+| Nathan James
+| n.james93 at hotmail.co.uk (email), njames93 (GitHub)
+
+
+clangd
+------
+| Sam McCall
+| sammccall at google.com (email), sam-mccall (GitHub), sam-mccall (Discourse), sam-mccall (Discord)

>From 37469f955bc3afecc8b6c0db9624cd6c932e895e Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Fri, 1 Nov 2024 11:01:23 -0400
Subject: [PATCH 2/5] Move Nathan to the inactive maintainers section

Based on review feedback from Nathan -- thank you for all the help!
---
 clang-tools-extra/Maintainers.txt | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index dc60b3717c63bb..db6091175d6c66 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -30,13 +30,18 @@ clang-doc
 | juliehockett at google.com (email)
 
 
-clang-tidy
-----------
-| Nathan James
-| n.james93 at hotmail.co.uk (email), njames93 (GitHub)
-
-
 clangd
 ------
 | Sam McCall
 | sammccall at google.com (email), sam-mccall (GitHub), sam-mccall (Discourse), sam-mccall (Discord)
+
+
+Inactive Maintainers
+====================
+The following people have graciously spent time performing maintainership
+responsibilities but are no longer active in that role. Thank you for all your
+help with the success of the project!
+
+Inactive component maintainers
+------------------------------
+| Nathan James (n.james93 at hotmail.co.uk) -- clang-tidy

>From 54b478eeaeeaa0c7bb0b58630e2d3d12100d2c9c Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 13 Nov 2024 10:39:37 -0500
Subject: [PATCH 3/5] Add Congcong Cai as a maintainer for clang-tidy

---
 clang-tools-extra/Maintainers.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index db6091175d6c66..61fd049ec168b8 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -18,6 +18,12 @@ Lead Maintainer
 | klimek at google.com (email), r4nt (GitHub)
 
 
+clang-tidy
+----------
+| Congcong Cai
+| congcongcai0907\@163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
+
+
 clang-query
 -----------
 | Aaron Ballman

>From c7c2e377a68b6a2a4931f38ef813124fe5aa04b2 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 13 Nov 2024 14:02:07 -0500
Subject: [PATCH 4/5] Add Julian Schmidt as a maintainer for clang-tidy

---
 clang-tools-extra/Maintainers.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index 61fd049ec168b8..b6ac5651006bc2 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -23,6 +23,9 @@ clang-tidy
 | Congcong Cai
 | congcongcai0907\@163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
 
+| Julian Schmidt
+| git.julian.schmidt\@gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
+
 
 clang-query
 -----------

>From 307b210f270b6eeb1d860fd570de227def325ee1 Mon Sep 17 00:00:00 2001
From: Aaron Ballman <aaron at aaronballman.com>
Date: Wed, 13 Nov 2024 14:18:19 -0500
Subject: [PATCH 5/5] No need to escape the @

---
 clang-tools-extra/Maintainers.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/clang-tools-extra/Maintainers.txt b/clang-tools-extra/Maintainers.txt
index b6ac5651006bc2..c3536a570fb519 100644
--- a/clang-tools-extra/Maintainers.txt
+++ b/clang-tools-extra/Maintainers.txt
@@ -21,10 +21,10 @@ Lead Maintainer
 clang-tidy
 ----------
 | Congcong Cai
-| congcongcai0907\@163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
+| congcongcai0907 at 163.com (email), HerrCai0907 (GitHub), HerrCai0907 (Discourse)
 
 | Julian Schmidt
-| git.julian.schmidt\@gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
+| git.julian.schmidt at gmail.com (email), 5chmidti (GitHub), 5chmidti (Discourse), 5chmidti (Discord)
 
 
 clang-query



More information about the cfe-commits mailing list