[libclc] [libclc] Move sign to the CLC builtins library (PR #115699)

Matt Arsenault via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 12 08:19:45 PST 2024


================
@@ -322,22 +322,26 @@ foreach( t ${LIBCLC_TARGETS_TO_BUILD} )
 
     if ( ARCH STREQUAL spirv OR ARCH STREQUAL spirv64 )
       set( build_flags -O0 -finline-hint-functions -DCLC_SPIRV )
-      set( opt_flags )
+      set( clc_opt_flags )
+      # Inline CLC functions into OpenCL builtins
+      set( opencl_opt_flags "--passes=always-inline" )
----------------
arsenm wrote:

I mean across the whole of libclc. 

> But the SPIR-V/Mesa targets seem quite explicit that they don't want any optimizations

This is nonsense. There are optimizations we should restrict as fancy compression, but the libraries should certainly be optimized. 

> out of optimizations because the SPIR-V translator couldn't handle optimized LLVM IR

If anything, I would expect the opposite 

https://github.com/llvm/llvm-project/pull/115699


More information about the cfe-commits mailing list