[clang] [clang][serialization] Enable `ASTWriter` to work with `Preprocessor` only (PR #115237)

Ben Langmuir via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 11 10:05:43 PST 2024


================
@@ -661,8 +661,8 @@ class ASTWriter : public ASTDeserializationListener,
 
   /// Write a precompiled header for the given semantic analysis.
   ///
-  /// \param SemaRef a reference to the semantic analysis object that processed
-  /// the AST to be written into the precompiled header.
+  /// \param Subject The object that processed the input to be written into the
+  /// AST file.
----------------
benlangmuir wrote:

The first line of the doc comment above also mentions semantic analysis.  I wonder if it would help to spell out the use case more explicitly and say something along these lines:

Write a precompiled header or module for an AST with the given semantic analysis, or a dependency scanner module for an input using the given preprocessor.

\param Subject The semantic analysis object that processed the AST to be written, or in the case of a dependency scanner module the preprocessor that processed the input.

https://github.com/llvm/llvm-project/pull/115237


More information about the cfe-commits mailing list