[clang] [clang-tools-extra] [analyzer] Remove alpha.core.IdenticalExpr Checker (PR #114715)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Nov 8 05:51:50 PST 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 0daca808ce111f21db8c0ee9ea5d2509d6034557 8f80764dd43013d9f6fbd1bb45642a1bfa4eab9e --extensions cpp -- clang-tools-extra/clang-tidy/bugprone/BranchCloneCheck.cpp clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone/alpha-core-identicalexpr.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp b/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
index bb8418ba43..cab7a20105 100644
--- a/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
+++ b/clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp
@@ -865,20 +865,18 @@ void RedundantExpressionCheck::registerMatchers(MatchFinder *Finder) {
// Binary with equivalent operands, like (X != 2 && X != 2).
Finder->addMatcher(
- traverse(
- TK_AsIs,
- binaryOperator(
- anyOf(isComparisonOperator(),
- hasAnyOperatorName("-", "/", "%", "|", "&", "^", "&&", "||",
- "=")),
- operandsAreEquivalent(),
- // Filter noisy false positives.
- unless(isInTemplateInstantiation()),
- unless(binaryOperatorIsInMacro()),
- unless(hasAncestor(arraySubscriptExpr())),
- unless(hasDescendant(BannedIntegerLiteral)),
- unless(IsInUnevaluatedContext))
- .bind("binary")),
+ traverse(TK_AsIs,
+ binaryOperator(anyOf(isComparisonOperator(),
+ hasAnyOperatorName("-", "/", "%", "|", "&",
+ "^", "&&", "||", "=")),
+ operandsAreEquivalent(),
+ // Filter noisy false positives.
+ unless(isInTemplateInstantiation()),
+ unless(binaryOperatorIsInMacro()),
+ unless(hasAncestor(arraySubscriptExpr())),
+ unless(hasDescendant(BannedIntegerLiteral)),
+ unless(IsInUnevaluatedContext))
+ .bind("binary")),
this);
// Logical or bitwise operator with equivalent nested operands, like (X && Y
``````````
</details>
https://github.com/llvm/llvm-project/pull/114715
More information about the cfe-commits
mailing list