[clang-tools-extra] [clangd] [Modules] Support Reusable Modules Builder (PR #106683)

kadir çetinkaya via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 8 05:46:23 PST 2024


================
@@ -124,10 +164,34 @@ struct ModuleFile {
       llvm::sys::fs::remove(ModuleFilePath);
   }
 
+  StringRef getModuleName() const { return ModuleName; }
+
+  StringRef getModuleFilePath() const { return ModuleFilePath; }
+
+private:
   std::string ModuleName;
   std::string ModuleFilePath;
+
+  // The required module files. We need to share the ownership for required
+  // module files.
+  ReusablePrerequisiteModules RequiredModuleFiles;
----------------
kadircet wrote:

why?

since `ModuleFile`s are kept alive by `ReusablePrerequisiteModules`, all of their dependencies should be alive as well, no?

https://github.com/llvm/llvm-project/pull/106683


More information about the cfe-commits mailing list