[clang] [lldb] [llvm] [AArch64] Reduce +sve2-aes to an alias of +sve-aes+sve2 (PR #114293)

Maciej Gabka via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 6 06:06:02 PST 2024


================
@@ -369,9 +369,12 @@ def FeatureSVE2 : ExtensionWithMArch<"sve2", "SVE2", "FEAT_SVE2",
   "Enable Scalable Vector Extension 2 (SVE2) instructions",
   [FeatureSVE, FeatureUseScalarIncVL]>;
 
-def FeatureSVE2AES : ExtensionWithMArch<"sve2-aes", "SVE2AES",
+def FeatureSVEAES : ExtensionWithMArch<"sve-aes", "SVEAES",
   "FEAT_SVE_AES, FEAT_SVE_PMULL128",
-  "Enable AES SVE2 instructions", [FeatureSVE2, FeatureAES]>;
+  "Enable SVE AES and 128-bit PMULL instructions", [FeatureAES]>;
----------------
mgabka wrote:

I think that would be more clear, from the original text I think it looked more like the SVE relates only to the AES, not to PMULL, and PMULL has variants for NEON and SVE.

https://github.com/llvm/llvm-project/pull/114293


More information about the cfe-commits mailing list