[clang] [llvm] [MIPS] LLVM data layout give i128 an alignment of 16 for mips64 (PR #112084)

via cfe-commits cfe-commits at lists.llvm.org
Wed Nov 6 00:58:54 PST 2024


yingopq wrote:

> > > > @nikic I checked several other arch-32 situations with ForceEnableInt128, and they all use `alloca i128, align 16`. But they did not modify the target datalayout content with `i128:128`, should mips be consistent?
> > > 
> > > 
> > > I think either way is fine here. Something to consider though, is that the AutoUpgrade for the DataLayout has to match. So if you don't add `i128:128` to the o32 DL, then it shouldn't get added by AutoUpgrade either.
> > 
> > 
> > OK, I decided to not add this. Please help review whether there has other issue, thanks!
> 
> In that case we also need to prevent the auto-upgrade if the o32 ABI is used. Otherwise auto-upgrade will produce the i128:128 data layout for o32, which directly targeting it would not.

OK, I updated the AutoUpgrade.cpp.

https://github.com/llvm/llvm-project/pull/112084


More information about the cfe-commits mailing list