[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

Hubert Tong via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 20:39:17 PST 2024


================
@@ -2378,13 +2394,28 @@ MCSection *TargetLoweringObjectFileXCOFF::getExplicitSectionGlobal(
   StringRef SectionName = GO->getSection();
----------------
hubert-reinterpretcast wrote:

See `report_fatal_error` above.
I think the new code should be moved up so that `SectionName` is correct by the time we reach the next line.

I also believe that this `pragma` should suppress the application of `-mtocdata`.
For explicit section attributes and `-mtocdata=<var>`, there is a warning implemented:
```
-mtocdata option is ignored for <var> because variable has a section attribute
```

https://github.com/llvm/llvm-project/pull/112714


More information about the cfe-commits mailing list