[clang-tools-extra] [clang-tidy] Filter out googletest TUs in bugprone-unchecked-optional-access (PR #115051)

Jan Voung via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 13:35:03 PST 2024


jvoung wrote:

> Relying on Google-test internal implementation details that are outside of our control and may change at any point in time does not feel good.
> 
> The patch should instead fix the root cause of the problem.

I agree that it's not good to rely on implementation details, but these are not internal implementation details - these are key elements of the *public API* , which trip up the analysis. It's not just any macros that we have a problem with, it's specifically the googletest macros, which we don't properly understand, resulting in false positives.


https://github.com/llvm/llvm-project/pull/115051


More information about the cfe-commits mailing list