[clang] clang/AMDGPU: Emit grid size builtins with range metadata (PR #113038)

Louis Dionne via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 08:34:49 PST 2024


ldionne wrote:

I'm not sure what's special about your usage of Graphite, but I've seen other people use it without triggering these notifications to everyone. This is disruptive: if everyone started doing this, our Github notification system with CODEOWNERS.txt would break down completely because we'd get hundreds of spam notifications a day.

I don't use Graphite, so I don't understand what might be going wrong for certain. But this force-push seems to be the culprit:
<img width="892" alt="Screenshot 2024-11-05 at 11 28 13" src="https://github.com/user-attachments/assets/83a87afa-9220-4df0-a991-623a5af98328">

If you click on `Compare`, you'll see it caused the PR to affect like 3000 files, which notified everyone associated to these files. I see that you *then* updated the base branch to `main`, which reduced the diff to just *your* changes. I think you need to do it the other way around: First, change the base branch to `main`, and then rebase on top of it and force-push. That way, the diff from your branch towards the base branch will never contain more than your own changes.

https://github.com/llvm/llvm-project/pull/113038


More information about the cfe-commits mailing list