[clang] [clang] Make source locations space usage diagnostics numbers easier to read (PR #114999)

Ilya Biryukov via cfe-commits cfe-commits at lists.llvm.org
Tue Nov 5 08:22:40 PST 2024


================
@@ -2227,6 +2227,28 @@ LLVM_DUMP_METHOD void SourceManager::dump() const {
   }
 }
 
+static std::string NumberToHumanString(uint64_t Number) {
----------------
ilya-biryukov wrote:

LLVM Style guide asks to use `camelCase` and a verb phrase (see https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly). `Number` also seems a bit redundant, because it's the first parameter anyway.

Let's turn this to `camelCase`?
Extra suggestion (optional): Maybe rename to `toHumanString`?

https://github.com/llvm/llvm-project/pull/114999


More information about the cfe-commits mailing list