[clang] [CIR] Call code gen; create empty cir.func op (PR #113483)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 1 05:55:34 PDT 2024


================
@@ -10,4 +10,57 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include <clang/CIR/Dialect/IR/CIRDialect.h>
+#include "clang/CIR/Dialect/IR/CIRDialect.h"
+
+#include "mlir/Support/LogicalResult.h"
+
+#include "clang/CIR/Dialect/IR/CIROpsDialect.cpp.inc"
----------------
AaronBallman wrote:

> The TableGen'erated file doesn't have its own includes. So it needs to be last, to rely on the includes of the main .cpp file.

I think that should probably change (though I don't think it needs to as part of this patch) because relying on transitive includes is rarely a good thing for long-term maintenance.

https://github.com/llvm/llvm-project/pull/113483


More information about the cfe-commits mailing list