[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

David Spickett via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 1 02:26:36 PDT 2024


================
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal(
       Name == getInstrProfSectionName(IPSK_covname, Triple::COFF,
                                       /*AddSegmentInfo=*/false))
     Kind = SectionKind::getMetadata();
+
+  const GlobalVariable *GV = dyn_cast<GlobalVariable>(GO);
+  if (GV && GV->hasImplicitSection()) {
+    auto Attrs = GV->getAttributes();
+    if (Attrs.hasAttribute("bss-section") && Kind.isBSS()) {
----------------
DavidSpickett wrote:

I think https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements applies here.

Despite clang-format deciding to put one of the conditions onto 2 lines.

https://github.com/llvm/llvm-project/pull/112714


More information about the cfe-commits mailing list