[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

Tom Honermann via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 31 07:36:15 PDT 2024


================
@@ -14296,6 +14296,31 @@ void ASTContext::getFunctionFeatureMap(llvm::StringMap<bool> &FeatureMap,
   }
 }
 
+static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context,
+                                          CanQualType KernelNameType,
+                                          const FunctionDecl *FD) {
+  return { KernelNameType, FD };
+}
+
+void ASTContext::registerSYCLEntryPointFunction(FunctionDecl *FD) {
+  assert(!FD->isInvalidDecl());
+  assert(!FD->isDependentContext());
----------------
tahonermann wrote:

I'm struggling with GitHub hiding comments too. The only reliable way I've found to make sure I'm following up on all of them is to stay in the conversation tab, scroll slowly from the top, expanding collapsed sections and resolved conversations as I go. Comments on "outdated" files seem to be implicitly hidden or at least aren't shown on the files tab at all. There have been numerous times where I know a conversation happened and it takes me a long time to find it again. Page searches don't identify text in collapsed sections (at least not always). Quite frustrating. I still miss Phabricator. Anyway, I digress.

Thank you for pointing me to `isTemplated()`. It uses `isDependentContext()`, but has special handling for friend and local function declarations. I think this should be using `isTemplated()`, so I'll change that and look to see if test updates are appropriate. Good catch.

https://github.com/llvm/llvm-project/pull/111389


More information about the cfe-commits mailing list