[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 30 07:47:04 PDT 2024


================
@@ -407,7 +407,8 @@ def MicrosoftExt : LangOpt<"MicrosoftExt">;
 def Borland : LangOpt<"Borland">;
 def CUDA : LangOpt<"CUDA">;
 def HIP : LangOpt<"HIP">;
-def SYCL : LangOpt<"SYCLIsDevice">;
+def SYCLHost : LangOpt<"SYCLIsHost">;
----------------
erichkeane wrote:

Those are a weird choice too IMO.  I think we inherited that without much review from the downstream, but I kind of want to push back.  The `-is` doesn't really buy us anything here.  I'd accept the flag as an alias, though I'm not sure how much value there is as we aren't really functional in the upstream, so our users are limited.

https://github.com/llvm/llvm-project/pull/111389


More information about the cfe-commits mailing list