[clang] [clang][deps] Stop sorting file dependencies (PR #114079)

Jan Svoboda via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 29 15:27:28 PDT 2024


================
@@ -472,7 +465,8 @@ class FullDeps {
             JOS.attributeArray("command-line",
                                toJSONStrings(JOS, MD.getBuildArguments()));
             JOS.attribute("context-hash", StringRef(MD.ID.ContextHash));
-            JOS.attributeArray("file-deps", toJSONSorted(JOS, MD.FileDeps));
+            // TODO: Shuffle these to prevent tests from depending on the order.
----------------
jansvoboda11 wrote:

Hmm, I wanted to seed the random shuffle with something "stable" (like the repo revision number) to be able to diff in tests. I also wanted to add a `clang-scan-deps` flag to disable it entirely for development purposes. Is that something that you still consider a bad idea?

https://github.com/llvm/llvm-project/pull/114079


More information about the cfe-commits mailing list