[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 29 08:27:20 PDT 2024


================
@@ -51,14 +51,15 @@ DefaultTemplateArgumentContainsUnexpandedPack(const TemplateParam &P) {
          P.getDefaultArgument().getArgument().containsUnexpandedParameterPack();
 }
 
-TemplateParameterList::TemplateParameterList(const ASTContext& C,
+TemplateParameterList::TemplateParameterList(const ASTContext &C,
                                              SourceLocation TemplateLoc,
                                              SourceLocation LAngleLoc,
                                              ArrayRef<NamedDecl *> Params,
                                              SourceLocation RAngleLoc,
                                              Expr *RequiresClause)
-    : TemplateLoc(TemplateLoc), LAngleLoc(LAngleLoc), RAngleLoc(RAngleLoc),
-      NumParams(Params.size()), ContainsUnexpandedParameterPack(false),
+    : InjectedArgs(&C), TemplateLoc(TemplateLoc), LAngleLoc(LAngleLoc),
----------------
erichkeane wrote:

>Fixing existing code should be trivial, I just really dislike "getters" with parameters :P 
I'm not THRILLED with it either, though we do this with `ASTContext` all over the place in the codebase to mean 'this probably needs to allocate'.  But thank you for your patience/flexibility here.

https://github.com/llvm/llvm-project/pull/113579


More information about the cfe-commits mailing list