[clang] [Clang][AST] Store injected template arguments in TemplateParameterList (PR #113579)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 29 06:47:56 PDT 2024
================
@@ -51,14 +51,15 @@ DefaultTemplateArgumentContainsUnexpandedPack(const TemplateParam &P) {
P.getDefaultArgument().getArgument().containsUnexpandedParameterPack();
}
-TemplateParameterList::TemplateParameterList(const ASTContext& C,
+TemplateParameterList::TemplateParameterList(const ASTContext &C,
SourceLocation TemplateLoc,
SourceLocation LAngleLoc,
ArrayRef<NamedDecl *> Params,
SourceLocation RAngleLoc,
Expr *RequiresClause)
- : TemplateLoc(TemplateLoc), LAngleLoc(LAngleLoc), RAngleLoc(RAngleLoc),
- NumParams(Params.size()), ContainsUnexpandedParameterPack(false),
+ : InjectedArgs(&C), TemplateLoc(TemplateLoc), LAngleLoc(LAngleLoc),
----------------
erichkeane wrote:
My hope would be that the callers there could pass on their AST Context, I see the uses in this review are either already have an ASTContext or access to Sema. Could you do that (add it as a parm to the `getInjectedTemplateArgs`, and see how rough it is for the callers to get the ASTContext), and put it somewhere I can take a look? If it ends up getting too rough in some places, I think i could 'disagree and commit' to this approach.
https://github.com/llvm/llvm-project/pull/113579
More information about the cfe-commits
mailing list