[clang] [clang] Implement P2582R1: CTAD from inherited constructors (PR #98788)

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 28 23:51:29 PDT 2024


================
@@ -1960,24 +1960,38 @@ class ExplicitSpecifier {
 class CXXDeductionGuideDecl : public FunctionDecl {
   void anchor() override;
 
+public:
+  enum class SourceKind {
----------------
hokein wrote:

@cor3ntin, if you have any ideas for a better name, could you suggest one?

I think adding a few comments to the enum should suffice. Personally, I like `SourceKind` — it's short, clear, and works well as `CXXDeductionGuideDecl::SourceKind::XXX`.

On the other hand, `SourceDeductionGuideKind` feels a bit lengthy and redundant with "DeductionGuide" already in the context.

https://github.com/llvm/llvm-project/pull/98788


More information about the cfe-commits mailing list