[clang] [clang][ExprConst] Reject field access with nullptr base (PR #113885)

[Richard Smith via cfe-commits]

================
@@ -1703,7 +1703,7 @@ namespace {
     bool checkNullPointerDiagnosingWith(const GenDiagType &GenDiag) {
       if (Designator.Invalid)
         return false;
-      if (IsNullPtr) {
+      if (getLValueBase().isNull()) {
----------------
zygoloid wrote:

Why was the old check not good enough here? In the added testcase, `nb` is a null pointer.

https://github.com/llvm/llvm-project/pull/113885