[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 28 08:03:08 PDT 2024
================
@@ -407,7 +407,8 @@ def MicrosoftExt : LangOpt<"MicrosoftExt">;
def Borland : LangOpt<"Borland">;
def CUDA : LangOpt<"CUDA">;
def HIP : LangOpt<"HIP">;
-def SYCL : LangOpt<"SYCLIsDevice">;
+def SYCLHost : LangOpt<"SYCLIsHost">;
----------------
erichkeane wrote:
Is the `Is` well motivated in these lang-opts? I realize `historical reasons`, but i find myself questioning the naming here. `SYCLDevice` and `SYCLHost` is perhaps fine. Also-also, I find myself thinking that to match the coding standard, these should use `Sycl`. IDK why CUDA doesn't follow the rule (I think only 3 letter acronyms can be capital?).
https://github.com/llvm/llvm-project/pull/111389
More information about the cfe-commits
mailing list