[clang-tools-extra] [clangd] fix extract-to-function for overloaded operators (PR #81640)
Julian Schmidt via cfe-commits
cfe-commits at lists.llvm.org
Sat Oct 26 03:23:09 PDT 2024
================
@@ -104,9 +104,12 @@ bool isRootStmt(const Node *N) {
// Root statement cannot be partially selected.
if (N->Selected == SelectionTree::Partial)
return false;
- // Only DeclStmt can be an unselected RootStmt since VarDecls claim the entire
- // selection range in selectionTree.
- if (N->Selected == SelectionTree::Unselected && !N->ASTNode.get<DeclStmt>())
+ // A DeclStmt can be an unselected RootStmt since VarDecls claim the entire
+ // selection range in selectionTree. Additionally, a CXXOperatorCallExpr of a
+ // binary operation can be unselected because it's children claim the entire
----------------
5chmidti wrote:
```suggestion
// selection range in selectionTree. Additionally, a CXXOperatorCallExpr of a
// binary operation can be unselected because its children claim the entire
```
https://github.com/llvm/llvm-project/pull/81640
More information about the cfe-commits
mailing list