[clang] [llvm] Introduce a new WebKit checker for a unchecked local variable (PR #113708)
via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 25 09:32:06 PDT 2024
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff 5c20891b2bb60f82dd82a8e90b111f8c13a13ad4 cf5ca301bc9ed2c65eed92e7299bf598d5f88103 --extensions cpp,h -- clang/test/Analysis/Checkers/WebKit/unchecked-local-vars.cpp clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.h clang/test/Analysis/Checkers/WebKit/mock-types.h clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
index 5d39d02a2f..46819d5ca1 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/PtrTypesSemantics.cpp
@@ -200,8 +200,7 @@ std::optional<bool> isUncountedPtr(const QualType T) {
return false;
}
-std::optional<bool> isUncheckedPtr(const QualType T)
-{
+std::optional<bool> isUncheckedPtr(const QualType T) {
if (T->isPointerType() || T->isReferenceType()) {
if (auto *CXXRD = T->getPointeeCXXRecordDecl())
return isUnchecked(CXXRD);
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp
index 0842cdbc40..0781471d73 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLocalVarsChecker.cpp
@@ -109,7 +109,7 @@ class RawPtrRefLocalVarsChecker
mutable BugReporter *BR;
public:
- RawPtrRefLocalVarsChecker(const char* description)
+ RawPtrRefLocalVarsChecker(const char *description)
: Bug(this, description, "WebKit coding guidelines") {}
virtual std::optional<bool> isUnsafePtr(const QualType T) const = 0;
``````````
</details>
https://github.com/llvm/llvm-project/pull/113708
More information about the cfe-commits
mailing list