[clang] [clang][Driver][HIP] Add support for mixing AMDGCNSPIRV & concrete `offload-arch`s. (PR #113509)

Joseph Huber via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 25 09:08:14 PDT 2024


================
@@ -264,12 +264,14 @@ void HIPAMDToolChain::addClangTargetOptions(
     CC1Args.push_back("-fapply-global-visibility-to-externs");
   }
 
-  // For SPIR-V we embed the command-line into the generated binary, in order to
-  // retrieve it at JIT time and be able to do target specific compilation with
-  // options that match the user-supplied ones.
-  if (getTriple().isSPIRV() &&
-      !DriverArgs.hasArg(options::OPT_fembed_bitcode_marker))
-    CC1Args.push_back("-fembed-bitcode=marker");
+  if (getEffectiveTriple().isSPIRV()) {
----------------
jhuber6 wrote:

I remember seeing an existing way to do this for LTO or something but I don't remember.

https://github.com/llvm/llvm-project/pull/113509


More information about the cfe-commits mailing list