[clang] [clang][dataflow] Disambiguate a ref to "internal" in CachedConstAccessorsLattice (PR #113601)

Jan Voung via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 25 06:40:55 PDT 2024


jvoung wrote:

> AST_MATCHER_P_OVERLOAD

Ah, missed the part where the macro is generating the `internal` namespaces. I don't think we want to move to the top of the file exactly (the instantiation refers to some functions defined right above, so would need fwd decls?), but we can change the namespacing inline `} ... {`.

There seem to be other recommendations in the header https://github.com/llvm/llvm-project/blob/6854ad90e39e9d119c990043f573db7157a2b097/clang/include/clang/ASTMatchers/ASTMatchersMacros.h#L26
like putting in `clang::ast_matchers::unnamed...` (though I'm not sure if they mean exactly `clang::ast_matchers`.

Let me try and check with the team.


https://github.com/llvm/llvm-project/pull/113601


More information about the cfe-commits mailing list