[clang] [Driver] Remove ignored Flag form of -fauto-profile/-fprofile-sample-use (PR #113528)
Fangrui Song via cfe-commits
cfe-commits at lists.llvm.org
Thu Oct 24 09:49:34 PDT 2024
MaskRay wrote:
> This would close #112391
>
> I am copying my comment from my PR #112750 which addresses the issue #112391: I think this isn't the best solution, since it is inconsistent with the behavior of the -fprofile-use option. Why should -fprofile-use be accepted and -fprofile-sample-use rejected? TBH I think the whole looking for default filename isn't the best option, but to make things consistent it seems to easier to introduce this behavior for -fprofile-sample/auto-use rather than take it from -fprofile-use
I know this is a bit inconsistent, and the original patch in 2017 probably should not have added -fauto-profile/-fauto-profile= in the first place (unneeded, incompatible with GCC anyway).
I think this is a little compatibility argument to retain `-fprofile-use`, but there isn't any for `-fprofile-sample-use=`. The usual filename is `*.afdo` `*.xfdo`, not `.profdata` (indexed profile format).
https://github.com/llvm/llvm-project/pull/113528
More information about the cfe-commits
mailing list