[clang] [llvm] [mlir] [OpenMP][OMPIRBuilder] Error propagation across callbacks (PR #112533)

Sergio Afonso via cfe-commits cfe-commits at lists.llvm.org
Wed Oct 23 05:04:24 PDT 2024


================
@@ -1171,12 +1179,15 @@ void OpenMPIRBuilder::emitCancelationCheckImpl(Value *CancelFlag,
   // post finalization block that is known to the FiniCB callback.
   Builder.SetInsertPoint(CancellationBlock);
   if (ExitCB)
-    ExitCB(Builder.saveIP());
+    if (Error Err = ExitCB(Builder.saveIP()))
+      return std::move(Err);
----------------
skatrak wrote:

Thank you for the pointers @tblah, I wasn't aware of this detail. I've now removed all these redundant uses of `std::move`.

https://github.com/llvm/llvm-project/pull/112533


More information about the cfe-commits mailing list