[clang] [analyzer] Untangle subcheckers of CStringChecker (PR #113312)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Oct 22 20:04:22 PDT 2024
================
@@ -768,9 +776,17 @@ ProgramStateRef CStringChecker::CheckOverlap(CheckerContext &C,
std::tie(stateTrue, stateFalse) = state->assume(*OverlapTest);
if (stateTrue && !stateFalse) {
- // Overlap!
- emitOverlapBug(C, stateTrue, First.Expression, Second.Expression);
- return nullptr;
+ if (Filter.CheckCStringBufferOverlap) {
+ // Overlap!
----------------
isuckatcs wrote:
Nit: I think this comment is redudant as `emitOverlapBug()` clearly tells us that we found an overlap. What do you think about removing it?
https://github.com/llvm/llvm-project/pull/113312
More information about the cfe-commits
mailing list