https://github.com/isuckatcs commented: Apart from a few nits and the question about seeing new warning with a certain combination of checks, the patch looks good to me. https://github.com/llvm/llvm-project/pull/113312